Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Flaky generic tests on multiple threads #78

Closed
1 task done
heiderich opened this issue Mar 22, 2023 · 4 comments · Fixed by #79
Closed
1 task done

[Bug] Flaky generic tests on multiple threads #78

heiderich opened this issue Mar 22, 2023 · 4 comments · Fixed by #79
Assignees
Labels
bug Something isn't working

Comments

@heiderich
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Installing dbt-oracle 1.4.1 I suffer from dbt-labs/dbt-core#6885 (Flaky generic tests on multiple threads), because it hardly depends on dbt-core 1.4.4.

This issue is already fixed in dbt-core 1.4.5.

Could you bump the dependency from dbt-core from 1.4.4 to 1.4.5 (just as you did in #76)?

Expected Behavior

generic tests work using multiple threads

Steps To Reproduce

  1. Install dbt-oracle 1.4.1 (and thus dbt-core 1.4.4).
  2. Add a generic test.
  3. Use multiple threads.
  4. Run the tests.

(see dbt-labs/dbt-core#6885 for details)

Relevant log output using --debug flag enabled

No response

Environment

- OS: Linux
- Python: 3.8.10
- dbt: 1.4.4

What Oracle database version are you using dbt with?

No response

Additional Context

No response

@heiderich heiderich added the bug Something isn't working label Mar 22, 2023
@aosingh
Copy link
Member

aosingh commented Mar 22, 2023

@heiderich

I am working on upgrading dbt-core to v1.4.5

@aosingh aosingh self-assigned this Mar 22, 2023
@aosingh aosingh mentioned this issue Mar 22, 2023
@heiderich
Copy link
Author

Thanks @aosingh for taking care of this issue very quickly! Do you plan to release 1.4.2 soon?

@aosingh
Copy link
Member

aosingh commented Mar 23, 2023

@heiderich yes, mostly today. I will run the test suites and release it on PyPI

@aosingh
Copy link
Member

aosingh commented Mar 24, 2023

@heiderich 1.4.2 is available to install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants