Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TCK does not use metadata from declared dependencies #211

Closed
bclozel opened this issue Feb 1, 2023 · 0 comments · Fixed by #214
Closed

TCK does not use metadata from declared dependencies #211

bclozel opened this issue Feb 1, 2023 · 0 comments · Fixed by #214
Assignees
@melix
Labels
bug Something isn't working

Comments

@bclozel
Copy link
Collaborator

bclozel commented Feb 1, 2023 •
edited

Describe the bug
The TCK does not include metadata from declared dependencies. See this PR comment for context.

To Reproduce
Remove the configurationFileDirectories.from(tck.metadataRoot.dir... lines from the graphql-java-extended-validation TCK build.gradle and run:

./gradlew test -Pcoordinates=com.graphql-java:graphql-java-extended-validation:19.1

The test suite should fail on missing metadata related to jboss-logging, hibernate-validator and graphql-java - all libraries with actual metadata in this repository.

Expected behavior
The test should pass without manually adding the metadata for known dependencies listed in the "requires" attribute of the index.json document.
@bclozel bclozel added the bug Something isn't working label Feb 1, 2023
@bclozel bclozel mentioned this issue Feb 1, 2023
Merged
2 tasks
@melix melix self-assigned this Feb 1, 2023
melix added a commit to melix/graalvm-reachability-metadata that referenced this issue Feb 1, 2023
@melix
Fix "requires" clauses being ignored
8f53c8c 
This commit fixes the metadata repository not being used in the TCK.
Before, it was assumed that each test was working in isolation, but
in practice, oracle#211 showed that it is not the case.

So instead of the TCK figuring out by itself which metadata config
to include, and completely ignoring the "requires" clauses, we
will now simply configure the tests to use the metadata from the
current state of the repository. It makes things easier, at the
cost of possible side effects: it is possible that the metadata
from a transitive dependency is actually what makes a build pass.

However this drawback should be covered by regular code reviews,
as it is unexpected that metadata for a transitive "talks" about
the current module under test.

Fixes oracle#211
@melix melix mentioned this issue Feb 1, 2023
Merged
2 tasks
dnestoro pushed a commit that referenced this issue Feb 3, 2023
@melix @dnestoro
Fix "requires" clauses being ignored
bb1671b 
This commit fixes the metadata repository not being used in the TCK.
Before, it was assumed that each test was working in isolation, but
in practice, #211 showed that it is not the case.

So instead of the TCK figuring out by itself which metadata config
to include, and completely ignoring the "requires" clauses, we
will now simply configure the tests to use the metadata from the
current state of the repository. It makes things easier, at the
cost of possible side effects: it is possible that the metadata
from a transitive dependency is actually what makes a build pass.

However this drawback should be covered by regular code reviews,
as it is unexpected that metadata for a transitive "talks" about
the current module under test.

Fixes #211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melix melix

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix "requires" clauses being ignored melix/graalvm-reachability-metadata
2 participants
@bclozel @melix