Add metadata for graphql-java-extended-validation #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is currently in draft, as I'm hitting a strange issue. Manually adding the metadata to the test application solves the problem. I've also checked the metadata against a real application successfully. |
4 tasks
|
As discussed with the team, here's the output of the following command: It looks like the |
This was referenced Dec 21, 2022
bclozel
force-pushed
the
gql-validation
branch
2 times, most recently
from
81502fb
to
0b2dab5
Compare
Comment on lines
+21
to
+28
| graalvmNative { | ||
| binaries { | ||
| test { | ||
| buildArgs.add('--no-fallback') | ||
| buildArgs.add('-H:IncludeLocales=fr') | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
- You can change to the following block of code to verify ?
graalvmNative {
binaries {
test {
// We have to manually add the metadata because the org.graalvm.internal.tck gradle plugin does not automatically import
configurationFileDirectories.from(tck.metadataRoot.dir('com.graphql-java/graphql-java/19.2'))
configurationFileDirectories.from(tck.metadataRoot.dir('org.hibernate.validator/hibernate-validator/7.0.4.Final'))
}
}
}There was a problem hiding this comment.
No need to, I've manually copied those folders in the test and it worked. I guess this approach is more elegant but doesn't solve the TCK problem.
bclozel
force-pushed
the
gql-validation
branch
from
0b2dab5
to
3679bbe
Compare
|
I've applied a workaround for the TCK issue and created #211 to unlock this PR. |
bclozel
force-pushed
the
gql-validation
branch
2 times, most recently
from
a3b6f2c
to
bddee8e
Compare
|
I've just removed the workaround since the issue will be fixed when #214 is merged. |
dnestoro
force-pushed
the
gql-validation
branch
from
bddee8e
to
407eb4c
Compare
|
@dnestoro yes it's ready for review. I've removed the workaround on purpose. |
dnestoro
force-pushed
the
gql-validation
branch
from
407eb4c
to
b57c16a
Compare
melix
approved these changes
Feb 9, 2023
|
@dnestoro please merge! |
dnestoro
force-pushed
the
gql-validation
branch
from
b57c16a
to
53b2a65
Compare
corneil
pushed a commit
to corneil/graalvm-reachability-metadata
that referenced
this pull request
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR builds on the existing graphql-java metadata and adds the relevant content for the graphql-java-extended-validation artifact.
Checklist before merging
document)