Fix "requires" clauses being ignored #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the metadata repository not being used in the TCK. Before, it was assumed that each test was working in isolation, but in practice, oracle#211 showed that it is not the case. So instead of the TCK figuring out by itself which metadata config to include, and completely ignoring the "requires" clauses, we will now simply configure the tests to use the metadata from the current state of the repository. It makes things easier, at the cost of possible side effects: it is possible that the metadata from a transitive dependency is actually what makes a build pass. However this drawback should be covered by regular code reviews, as it is unexpected that metadata for a transitive "talks" about the current module under test. Fixes oracle#211
2 tasks
dnestoro
approved these changes
Feb 3, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the metadata repository not being used in the TCK. Before, it was assumed that each test was working in isolation, but in practice, #211 showed that it is not the case.
So instead of the TCK figuring out by itself which metadata config to include, and completely ignoring the "requires" clauses, we will now simply configure the tests to use the metadata from the current state of the repository. It makes things easier, at the cost of possible side effects: it is possible that the metadata from a transitive dependency is actually what makes a build pass.
However this drawback should be covered by regular code reviews, as it is unexpected that metadata for a transitive "talks" about the current module under test.
Fixes #211
What does this PR do?
Checklist before merging