Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home page project links missing webapp name #2802

Closed
cross opened this issue Jun 13, 2019 · 7 comments
Closed

Home page project links missing webapp name #2802

cross opened this issue Jun 13, 2019 · 7 comments
Assignees
Labels

Comments

@cross
Copy link
Contributor

cross commented Jun 13, 2019

Running a fairly recent build from head (1.2.9), I have found that the links to projects at the top-level web page do not include the web app name.

My app is reached at http://localhost:8080/source/, and there are two projects/repositories listed in the table below the search input fields. Each of these links to http://localhost:8080/xref/projectA, which doesn't work. The correct href should be http://localhost:8080/source/xref/projectA, which works when I manually adjust the URL.

I think these links used to be correct, and that I have used them before, but I cannot verify that at the moment.

Is this a tomcat config issue, or something wrong in opengrok?

@vladak
Copy link
Member

vladak commented Jun 13, 2019

possibly related to #2719

@vladak
Copy link
Member

vladak commented Jun 13, 2019

I can confirm - seeing the same.

vladak pushed a commit to vladak/OpenGrok that referenced this issue Jun 13, 2019
@vladak vladak self-assigned this Jun 13, 2019
@vladak vladak closed this as completed in b4532ba Jun 13, 2019
@IamTHEvilONE
Copy link
Contributor

IamTHEvilONE commented Jun 19, 2019

I'm still seeing this issue on 1.2.14 after upgrading, deploying the new WAR, and cleaning out the indexes and re-indexing (to push the new config).

The html code after generation looks like this:

<td class="name repository">
<a href="/xref/version"
 title="Xref for project version">
version
 </a>

so it's still not pulling the webapp name into it.

@vladak
Copy link
Member

vladak commented Jun 19, 2019

Looks like while request is implicit variable in JSP, it is not in JSTL: http://www.informit.com/articles/article.aspx?p=30946&seqNum=7

vladak pushed a commit to vladak/OpenGrok that referenced this issue Jun 19, 2019
@cross
Copy link
Contributor Author

cross commented Jun 20, 2019

Thank you @IamTHEvilONE . I was also still seeing it, but hadn't gotten to verifying that I'd cleared and flushed everything until today.
This issue should be reopened, @vladak ?
Hmm. I guess until 3af6c7c is committed and verified...

@vladak vladak reopened this Jun 20, 2019
@vladak
Copy link
Member

vladak commented Jun 20, 2019

Good question @cross, there does not seem to be established process for such case. Let's keep this simple for now.

@vladak vladak closed this as completed in 8f89b86 Jun 20, 2019
@IamTHEvilONE
Copy link
Contributor

Just commenting that this is fixed in release 1.2.16 when I was testing the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants