check Lucene index version before reindex #2087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
Pull Request Test Coverage Report for Build 2404
💛 - Coveralls |
ahornace
approved these changes
Apr 27, 2018
vladak
force-pushed
the
index_version_check
branch
from
aca32ae
to
8638c6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only captures when there is Lucene major version discrepancy. The
check()method can be updated later to cope with internal index changes.I had to add Lucene backward codecs so that the segment file can actually be opened. Otherwise it will result in
IllegalArgumentExceptionas noted in the issue.For now no data deletion is done, this is up to the user.