-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable JDK 11 builds #2525
enable JDK 11 builds #2525
Conversation
Pull Request Test Coverage Report for Build 3625
💛 - Coveralls |
Also, jacoco has to be upgraded: jacoco/jacoco#663 |
Another gotcha are JDK versions identified in the Maven profiles' |
fixes oracle#2522
Also, Due to this, I was not able to convert Jacoco to a profile like I did in https://github.com/vladak/maven-surefire Similarly, I wanted to make Coveralls to become Maven profile however this leads to AppVeyor failures since Coveralls does not have the auth token available there, unlike in Travis. |
A link a found handy: https://winterbe.com/posts/2018/08/29/migrate-maven-projects-to-java-11-jigsaw/ |
The major part of the change is passing
--illegal-access=permit
(and other options) tojava
for JDK 9+.I had to bump the chronicle-map to the latest release otherwise suggester tests were failing in
init()
.