Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable JDK 11 builds #2525

Merged
merged 2 commits into from
Nov 26, 2018
Merged

enable JDK 11 builds #2525

merged 2 commits into from
Nov 26, 2018

Conversation

vladak
Copy link
Member

@vladak vladak commented Nov 20, 2018

The major part of the change is passing --illegal-access=permit (and other options) to java for JDK 9+.

I had to bump the chronicle-map to the latest release otherwise suggester tests were failing in init().

@vladak vladak changed the title JDK 11 enable JDK 11 builds Nov 20, 2018
dev/install-python-packages.sh Outdated Show resolved Hide resolved
opengrok-indexer/pom.xml Outdated Show resolved Hide resolved
opengrok-indexer/pom.xml Show resolved Hide resolved
opengrok-web/pom.xml Outdated Show resolved Hide resolved
plugins/pom.xml Show resolved Hide resolved
suggester/pom.xml Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Nov 20, 2018

Pull Request Test Coverage Report for Build 3625

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.402%

Totals Coverage Status
Change from base Build 3615: 0.0%
Covered Lines: 32851
Relevant Lines: 44755

💛 - Coveralls

@vladak
Copy link
Member Author

vladak commented Nov 21, 2018

Also, jacoco has to be upgraded: jacoco/jacoco#663

@vladak
Copy link
Member Author

vladak commented Nov 22, 2018

Another gotcha are JDK versions identified in the Maven profiles' <activation> elements - e.g. JDK 8 is 1.8, JDK 11 is 18.9.

@vladak
Copy link
Member Author

vladak commented Nov 22, 2018

Also, jacoco:report has to be present on the Maven command line before the coveralls goal is invoked, otherwise the build fails with strange errors in Coveralls plugin processing - it will find that Jacoco reports line counts higher than the current length of some files (I think it was happening in the JavaScript generated lexer).

Due to this, I was not able to convert Jacoco to a profile like I did in https://github.com/vladak/maven-surefire

Similarly, I wanted to make Coveralls to become Maven profile however this leads to AppVeyor failures since Coveralls does not have the auth token available there, unlike in Travis.

@vladak
Copy link
Member Author

vladak commented Nov 22, 2018

@vladak vladak merged commit 3db0779 into oracle:master Nov 26, 2018
@vladak vladak deleted the jdk11 branch November 26, 2018 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants