Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hamlit: performance degraded due to missing Ripper.lex #1747

Closed
k0kubun opened this issue Sep 8, 2019 · 3 comments
Closed

hamlit: performance degraded due to missing Ripper.lex #1747

k0kubun opened this issue Sep 8, 2019 · 3 comments
Assignees
Milestone

Comments

@k0kubun
Copy link

k0kubun commented Sep 8, 2019

I added truffleruby support of Hamlit in k0kubun/hamlit#145, but it disabled various optimizations because Ripper.lex is not available in truffleruby.

It also complicated its implementation to guard against missing Ripper.lex. I really want truffleruby to support Ripper.lex, to make it easier to maintain the truffleruby support. Is there any plan to support Ripper.lex?

related to: #1712

@eregon
Copy link
Member

eregon commented Sep 8, 2019

Thank you again for adding TruffleRuby support in Hamlit.

We'll try to support Ripper.lex, it's one of the few missing stdlibs remaining: https://github.com/oracle/truffleruby/blob/master/doc/user/compatibility.md#standard-libraries

I expect there are no major issues to implement it, we can probably use a similar approach to JRuby as we share basically the same lexer and parser.

Note: this is also blocking haml (#1712)

@eregon
Copy link
Member

eregon commented Dec 20, 2019

Relates to #1585

@bjfish
Copy link
Contributor

bjfish commented Jul 17, 2020

@k0kubun Ripper has now been implemented and Ripper.lex is supported. Please let us know if you have any issues.

@bjfish bjfish closed this as completed Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants