Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed public list streaming #169

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

shayanjm
Copy link

Fixes #164 - the issue was with the way list tweets were getting accessed. I added a new arg property args.filter_ids which takes a string of comma separated twitter IDs of users and leverages the streaming statuses/filter endpoint (https://dev.twitter.com/streaming/reference/post/statuses/filter) for efficient list streaming.

The default filter functionality in draw() is still used to limit the drawn tweets to exactly what you'd expect the list timeline to return (tweets/rts/replies by the members of the list, but not all tweets at them) - hence why both args.filter_ids and args.filter need to exist as arg properties. Could be made more concise by making args.filter a list of tuples (username, user_id), but the current implementation works.

@orakaro orakaro force-pushed the master branch 3 times, most recently from 9a3b174 to 4f02522 Compare August 16, 2016 15:19
@ghost
Copy link

ghost commented Oct 24, 2016

@shayanjm Thanks! I have had problems with accessing public lists. I will test your changes.

@jcsackett
Copy link

I am currently running rainbowstream using the code from this PR and can confirm streaming a list with members I do not follow is working.

@jcsackett
Copy link

I've found an issue--it seems all tweets from members of the list are being shown. Including all replies. I'm unsure if this is a problem with the PR or if this is owing to some of the more obscure twitter api rules about when a mention/reply is and isn't supposed to be shown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants