Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LAN-611: OXD-Skeleton component added #709

Merged
merged 9 commits into from
Jul 7, 2023
Merged

LAN-611: OXD-Skeleton component added #709

merged 9 commits into from
Jul 7, 2023

Conversation

Super-Chama
Copy link
Member

@Super-Chama Super-Chama commented Jun 9, 2023 •
edited
Loading

Checklist

  • Test Coverage is 100% for the newly added code
  • Storybook stories are added/updated for the changed areas
  • Code is linted properly
  • Developer testing is done for the affected areas
  • Changelog.md updated on possible breaking changes

@Super-Chama Super-Chama marked this pull request as ready for review June 26, 2023 06:23
lgtkaushalya
lgtkaushalya reviewed Jun 28, 2023
View reviewed changes
components/src/composables/useFlashing.ts Show resolved Hide resolved
components/src/core/components/CardTable/Cell/LinkWithPill.vue Show resolved Hide resolved
components/src/core/components/CardTable/Cell/Checkbox.vue Outdated Show resolved Hide resolved
components/src/core/components/List2/List2.vue Show resolved Hide resolved
components/src/core/components/List2/list2.scss Show resolved Hide resolved
components/src/core/components/ListTable/ListTable.vue Outdated Show resolved Hide resolved
components/src/core/components/Skeleton/skeleton.scss Show resolved Hide resolved
storybook/stories/core/components/List2/List2.stories.js Show resolved Hide resolved
storybook/stories/core/components/ListTable/ListSkeleton.story.vue Show resolved Hide resolved
@lgtkaushalya
Copy link
Member

Have we added skeleton loading for all the inputs? if not we will have to do it at least after this rather than allowing other developers to do it within the features.

@lgtkaushalya lgtkaushalya merged commit e682ce9 into orangehrm:ent Jul 7, 2023
@Super-Chama Super-Chama deleted the LAN-611 branch July 10, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgtkaushalya lgtkaushalya lgtkaushalya left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Super-Chama @lgtkaushalya