Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix region and endpoint overrides #30

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Fix region and endpoint overrides #30

merged 1 commit into from
Nov 18, 2023

Conversation

lusingander
Copy link
Contributor

It seems that config is not overwritten correctly:

  • values are set to sess.Config (and cause panic)
  • endpoint setting is ignored

orangekame3
orangekame3 approved these changes Nov 18, 2023
View reviewed changes
Copy link
Owner

@orangekame3 orangekame3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM!

@orangekame3 orangekame3 merged commit 55064db into orangekame3:main Nov 18, 2023
1 check failed
@orangekame3 orangekame3 mentioned this pull request Nov 18, 2023
Merged
@lusingander lusingander deleted the fix-config branch November 18, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orangekame3 orangekame3 orangekame3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lusingander @orangekame3