Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: modernize Reference #93

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

shizhMSFT
Copy link
Contributor

What this PR does / why we need it

Modernize RemoteReference to Reference witht dotnet / C# features.

Which issue(s) this PR resolves / fixes

Resolve partially #91

Please check the following list

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (538d214) 72.35% compared to head (964d235) 71.32%.

Files Patch % Lines
src/OrasProject.Oras/Registry/Reference.cs 69.30% 26 Missing and 5 partials ⚠️
src/OrasProject.Oras/Registry/Remote/Repository.cs 88.23% 1 Missing and 1 partial ⚠️
src/OrasProject.Oras/Registry/Remote/Registry.cs 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
- Coverage   72.35%   71.32%   -1.04%     
==========================================
  Files          35       35              
  Lines        1013     1001      -12     
  Branches       93       97       +4     
==========================================
- Hits          733      714      -19     
- Misses        229      237       +8     
+ Partials       51       50       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sajayantony
Copy link
Contributor

Are you planning to bring up the code coverage for this? The changes are really good.

@shizhMSFT
Copy link
Contributor Author

Are you planning to bring up the code coverage for this? The changes are really good.

The purpose of this set of PRs are to modernize the code (i.e. focusing on interfaces). Perf improvement and code coverage will be future works.

Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit b6149d4 into oras-project:main Jan 3, 2024
7 checks passed
@shizhMSFT shizhMSFT deleted the refactor_ref branch January 10, 2024 03:11
@shizhMSFT shizhMSFT mentioned this pull request Jan 15, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants