-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding simple developer docs with example client #32
Conversation
also fixing bug that custom content type of layer is not set when provided. Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Going to test out my client before this is ready for review, will report back / update as needed. |
oooh nice found another bug!
|
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
…tname Signed-off-by: vsoch <vsoch@users.noreply.github.com>
a00b61f
to
2afddee
Compare
okay for my tester, it looks like the push isn't working with basic auth, I'm going to reproduce the request with my action and see if I can figure out why.
|
okay I think I see the problem but I'm not sure how to fix it:
I tried setting "scope" as a param to be the same as the above (but with push appended) and it didn't change the outcome. Update this is fixed! I had one line commented out that I forgot to uncomment that would update the PATCH request to include the token header. |
83e8853
to
7a6e2fa
Compare
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
7a6e2fa
to
66e0b9d
Compare
# Push Example | ||
reg = Registry() | ||
reg.set_basic_auth(user, token) | ||
reg.push("ghcr.io/vsoch/excellent-dinosaur:latest", archives) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are archives originating from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good question! It's just a lookup with filenames and then media types, and I didn't properly put it in the code but poorly showed it here: https://github.com/oras-project/oras-py/pull/32/files#diff-2f73f28403e770eba62d042f1e50ad0a240eb39585108e48497be198ca59f090R69-R70
I'll update this to explicitly have that named archives, and added to the example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay clarified here! 72afc46
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you @sabre1041 ! And especially given your travel and being busy! @sajayantony this is another one we will need your blessing on. Since one merge will warrant needing to update the second PR, my preference is to merge this one first, then I'll rebase #28 to make sure the fixes here still work. |
This PR aims to fix two issues that I just opened:
Signed-off-by: vsoch vsoch@users.noreply.github.com