Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: PoC for multi arch image create/update #1450

Closed
wants to merge 14 commits into from
Closed

feat: PoC for multi arch image create/update #1450

wants to merge 14 commits into from

Conversation

wangxiaoxuan273
Copy link
Contributor

@wangxiaoxuan273 wangxiaoxuan273 commented Jul 22, 2024 •
edited
Loading

Xiaoxuan Wang added 10 commits July 15, 2024 10:29
created manifest index subcommand
a42627b 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
auto detect platform
2e4dfb8 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
--add for update
bb60532 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
--remove for update
02abf45 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
parseTargetsFromStrings()
805bbc4 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
getPlatform()
65c03b9 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
packIndex()
7d7cb9a 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
fetchIndex()
f50a429 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
addManifests() and removeManifests()
8cea539 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
added poc
a6ac176 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
@codecov Codecov
Copy link

codecov bot commented Jul 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.74257% with 150 lines in your changes missing coverage. Please review.

Project coverage is 80.41%. Comparing base (d06bb81) to head (e0d922e).
Report is 40 commits behind head on main.

Files with missing lines Patch % Lines
cmd/oras/root/manifest/index/update.go 21.21% 77 Missing and 1 partial ⚠️
cmd/oras/root/manifest/index/create.go 22.58% 71 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1450      +/-   ##
==========================================
- Coverage   85.46%   80.41%   -5.06%     
==========================================
  Files         108      113       +5     
  Lines        3825     4094     +269     
==========================================
+ Hits         3269     3292      +23     
- Misses        332      576     +244     
- Partials      224      226       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

refinement
b5610fb 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
@sajayantony
Copy link
Contributor

Do you have some doc write up on how this works?

@wangxiaoxuan273
Copy link
Contributor Author

Do you have some doc write up on how this works?

@sajayantony I have a docs/proposals/multi-arch.md write up in this PR.

multiple tags
0294e94 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
qweeah
qweeah reviewed Jul 24, 2024
View reviewed changes
docs/proposals/multi-arch.md Show resolved Hide resolved
docs/proposals/multi-arch.md

- `--add`: Add a manifest to the index. The manifest will be added as the last element of the index.
- `--remove`: Remove a manifest from the index.
- `--annotation`: Update annotations for the index.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if a user is trying to remove an annotation?

docs/proposals/multi-arch.md Outdated Show resolved Hide resolved
docs/proposals/multi-arch.md Show resolved Hide resolved
docs/proposals/multi-arch.md
```

Flags:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to support add or remove artifact type and subject?

@TerryHowe
Copy link
Member

Would it be better to make a PR that isn't a draft with the doc so everyone can work out the details? After that merges, then a PR with the changes.

Xiaoxuan Wang added 2 commits August 9, 2024 14:35
merge flag for update
fcb746b 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
--tag for update
e0d922e 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
@wangxiaoxuan273
Copy link
Contributor Author

Would it be better to make a PR that isn't a draft with the doc so everyone can work out the details? After that merges, then a PR with the changes.

This draft PR is for demonstration and discussion purposes only. There will be formal PRs to implement the features.

@qweeah
Copy link
Contributor

qweeah commented Aug 9, 2024

@wangxiaoxuan273 I think what @TerryHowe means is to have separate a PR for the proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qweeah qweeah qweeah left review comments

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony will be requested when the pull request is marked ready for review sajayantony is a code owner

@shizhMSFT shizhMSFT Awaiting requested review from shizhMSFT shizhMSFT will be requested when the pull request is marked ready for review shizhMSFT is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker SteveLasker will be requested when the pull request is marked ready for review SteveLasker is a code owner

@TerryHowe TerryHowe Awaiting requested review from TerryHowe TerryHowe will be requested when the pull request is marked ready for review TerryHowe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support multi-arch image/artifact push
4 participants
@wangxiaoxuan273 @sajayantony @TerryHowe @qweeah