Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to oras-go library #265

Merged
merged 3 commits into from
May 6, 2021
Merged

Migrate to oras-go library #265

merged 3 commits into from
May 6, 2021

Conversation

jdolitsky
Copy link
Contributor

Git history has been migrated to the following new repositories:

This PR removes all code/docs that have been migrated to the above repos, and leaves behind only code related to the ORAS CLI.

CI/testing has been affected since the unit tests and acceptance tests are now in oras-go. Instead, I've added "make build-linux" and "oras version" to GHitHub actions to make sure the code at least builds. We should soon add some acceptance tests in this repo to make sure the CLI operates as expected (possibly a replacement for #257 )

Signed-off-by: Josh Dolitsky <josh@dolit.ski>
@jdolitsky jdolitsky requested review from deitch and shizhMSFT May 4, 2021 20:40
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
@jdolitsky
Copy link
Contributor Author

Note: I've also added commit c8ce737 to prep for a v0.12.0 release after this is merged

Copy link
Contributor

@deitch deitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do this. Separating it out gives us a whole future path for doing things with the CLI at its own pace.

The lack of tests is a little disconcerting, but the reality is that we never had CLI tests anyways. Should we? Sure. Does this change it? Actually it makes it better, but adding a few very basic smoke tests.

We have an open question about the library name, which should be resolved first, then this should get merged in.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdolitsky jdolitsky merged commit c9d1b33 into main May 6, 2021
@jdolitsky jdolitsky deleted the use-go-lib branch May 6, 2021 13:51
ndeloof added a commit to ndeloof/helm that referenced this pull request May 7, 2021
see oras-project/oras#265

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof mentioned this pull request May 7, 2021
3 tasks
ndeloof added a commit to ndeloof/helm that referenced this pull request May 25, 2021
see oras-project/oras#265

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof added a commit to ndeloof/helm that referenced this pull request Jul 19, 2021
see oras-project/oras#265

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
tylerauerbeck pushed a commit to tylerauerbeck/helm that referenced this pull request Aug 5, 2021
see oras-project/oras#265

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
tylerauerbeck pushed a commit to tylerauerbeck/helm that referenced this pull request Aug 5, 2021
see oras-project/oras#265

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
zak905 pushed a commit to zak905/helm that referenced this pull request Jan 19, 2023
see oras-project/oras#265

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants