-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to oras-go library #265
Conversation
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
Note: I've also added commit c8ce737 to prep for a v0.12.0 release after this is merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should do this. Separating it out gives us a whole future path for doing things with the CLI at its own pace.
The lack of tests is a little disconcerting, but the reality is that we never had CLI tests anyways. Should we? Sure. Does this change it? Actually it makes it better, but adding a few very basic smoke tests.
We have an open question about the library name, which should be resolved first, then this should get merged in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
see oras-project/oras#265 Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
see oras-project/oras#265 Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
see oras-project/oras#265 Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
see oras-project/oras#265 Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
see oras-project/oras#265 Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
see oras-project/oras#265 Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Git history has been migrated to the following new repositories:
This PR removes all code/docs that have been migrated to the above repos, and leaves behind only code related to the ORAS CLI.
CI/testing has been affected since the unit tests and acceptance tests are now in oras-go. Instead, I've added "make build-linux" and "oras version" to GHitHub actions to make sure the code at least builds. We should soon add some acceptance tests in this repo to make sure the CLI operates as expected (possibly a replacement for #257 )