-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging artifacts
Branch: Add discover comand
#419
Conversation
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: Billy Zha <qweeah@gmail.com>
ffcee8c
to
98e439e
Compare
artifacts
Branch: Add discover comand
98e439e
to
91505b0
Compare
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
…nto artifacts-discover Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
…nto artifacts-discover
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Can we put a screenshot of the command demo in the comment? |
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@Wwwsylvia Suppose we have
|
cmd/oras/discover.go
Outdated
`, | ||
Args: cobra.ExactArgs(1), | ||
PreRun: func(cmd *cobra.Command, args []string) { | ||
fmt.Println("Command discover is in preview and might have breaking changes coming.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's review the UX offline tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added latest
tag a default:
- Tree
Using default tag: latest
localhost:5000/net-monitor:latest
├── signature/example
│ └── sha256:2437d8720c28d2bd2ad830d218ebb47942c099e21ff9cf9abbeb5e396203f6dd
│ └── signature/example
│ └── sha256:7c8fa4053dd322a3c1ea069a43c2cfba90ef4db4c9fed71f10da9d3a2071479c
└── sbom/example
└── sha256:4b6726d63d4283fa579ddf29c4b0838025e2e27e5856e25db78fb50387461ee3
└── signature/example
└── sha256:673048d3beb0fada31b268b0e56a89c49fd6c0d2ec9b5ba63330e712b0c6758f
- Table
Using default tag: latest
Discovered 2 artifacts referencing localhost:5000/net-monitor:latest
Digest: sha256:4d5dd672805a7e20d19d1ae89bf4c5d371c47a018cb33bbc4dec989444602bd0
Artifact Type Digest
signature/example sha256:2437d8720c28d2bd2ad830d218ebb47942c099e21ff9cf9abbeb5e396203f6dd
sbom/example sha256:4b6726d63d4283fa579ddf29c4b0838025e2e27e5856e25db78fb50387461ee3
- JSON
Using default tag: latest
{
"referrers": [
{
"digest": "sha256:2437d8720c28d2bd2ad830d218ebb47942c099e21ff9cf9abbeb5e396203f6dd",
"mediaType": "application/vnd.cncf.oras.artifact.manifest.v1+json",
"artifactType": "signature/example",
"size": 411
},
{
"digest": "sha256:4b6726d63d4283fa579ddf29c4b0838025e2e27e5856e25db78fb50387461ee3",
"mediaType": "application/vnd.cncf.oras.artifact.manifest.v1+json",
"artifactType": "sbom/example",
"size": 401
}
]
}
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
This PR adds a new discover command, which can be used for searching referrer artifacts.
Resolves #382, related to #379