Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ghcr package action yaml #422

Merged
merged 2 commits into from
Jun 29, 2022
Merged

Update ghcr package action yaml #422

merged 2 commits into from
Jun 29, 2022

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Jun 27, 2022 •
edited
Loading

This PR rewrites give least privildege access to releasing github actions:

  • For binary release, the action need to read source code and write to release contents
  • For container image release, the action need to read source code and write to ghcr packages

Resolves #427

@qweeah qweeah changed the title Update makefile and ghcr package action yaml Update ghcr package action yaml Jun 27, 2022
Wwwsylvia
Wwwsylvia approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah
Add minimal permission for release action conf
d19ac38 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
Correct permissions
ea6bca4 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
shizhMSFT
shizhMSFT approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit abf310f into oras-project:main Jun 29, 2022
qweeah added a commit to qweeah/oras that referenced this pull request Jul 7, 2022
@qweeah
Update ghcr package action yaml (oras-project#422)
681d064 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wwwsylvia Wwwsylvia Wwwsylvia approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specify scopes for github token used in releases
3 participants
@qweeah @Wwwsylvia @shizhMSFT