Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty reference checking for discover cmd #442

Merged
merged 2 commits into from
Jul 8, 2022

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Jul 8, 2022

Resolves #439
Signed-off-by: Billy Zha jinzha1@microsoft.com

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah qweeah changed the title Add null reference checking for discover Add empty reference checking for discover Jul 8, 2022
@qweeah qweeah changed the title Add empty reference checking for discover Add empty reference checking for discover cmd Jul 8, 2022
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 2b400f4 into oras-project:main Jul 8, 2022
@qweeah qweeah deleted the fix-discover branch July 11, 2022 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return error if tag or digest is not specified
2 participants