Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: add FetchReference support in the caching proxy #464

Merged
merged 11 commits into from
Aug 12, 2022

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Jul 29, 2022

This PR adds FetchReference() for proxied cache, which will be used for optimizing fetching manifest content (when --descriptor is not provided) after oras.Resolve().

Related to #301

Signed-off-by: Billy Zha jinzha1@microsoft.com

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2022

Codecov Report

Merging #464 (43928a9) into main (96900e7) will increase coverage by 4.17%.
The diff coverage is 64.58%.

@@            Coverage Diff             @@
##             main     #464      +/-   ##
==========================================
+ Coverage   55.69%   59.87%   +4.17%     
==========================================
  Files           6        8       +2     
  Lines         237      309      +72     
==========================================
+ Hits          132      185      +53     
- Misses         90      103      +13     
- Partials       15       21       +6     
Impacted Files Coverage Δ
internal/cache/referenceTarget.go 58.33% <58.33%> (ø)
internal/cache/target.go 81.25% <70.83%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah qweeah changed the title Add FetchReference support in the proxy perf: add FetchReference support in the caching proxy Aug 8, 2022
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 6ca26fe into oras-project:main Aug 12, 2022
TerryHowe pushed a commit to TerryHowe/oras that referenced this pull request Feb 2, 2023
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants