Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use --artifact-type to change the media type of the config blob #482

Merged
merged 3 commits into from
Aug 9, 2022

Conversation

yuehaoliang
Copy link
Contributor

Resolve part of #466

Signed-off-by: Haoliang Yue yuehaoliang@microsoft.com

Signed-off-by: Haoliang Yue <yuehaoliang@microsoft.com>
Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The subject sounds more like 'ues artifact type flag to set config media type' to me.

cmd/oras/push.go Outdated Show resolved Hide resolved
cmd/oras/push.go Outdated Show resolved Hide resolved
cmd/oras/push.go Outdated Show resolved Hide resolved
…ovided

Signed-off-by: Haoliang Yue <yuehaoliang@microsoft.com>
cmd/oras/push.go Outdated Show resolved Hide resolved
Signed-off-by: Haoliang Yue <yuehaoliang@microsoft.com>
Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #482 (a2dbd63) into main (96900e7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #482   +/-   ##
=======================================
  Coverage   55.69%   55.69%           
=======================================
  Files           6        6           
  Lines         237      237           
=======================================
  Hits          132      132           
  Misses         90       90           
  Partials       15       15           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@shizhMSFT shizhMSFT merged commit d776a22 into oras-project:main Aug 9, 2022
TerryHowe pushed a commit to TerryHowe/oras that referenced this pull request Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants