Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move error to cmd internal packages #496

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Aug 15, 2022

And also update oras-go to rc2

@codecov-commenter
Copy link

Codecov Report

Merging #496 (7240609) into main (0c1856e) will increase coverage by 8.10%.
The diff coverage is 81.25%.

❗ Current head 7240609 differs from pull request most recent head 5d2b5d0. Consider uploading reports for the commit 5d2b5d0 to get more accurate results

@@            Coverage Diff             @@
##             main     #496      +/-   ##
==========================================
+ Coverage   59.47%   67.58%   +8.10%     
==========================================
  Files           7        7              
  Lines         306      327      +21     
==========================================
+ Hits          182      221      +39     
+ Misses        103       85      -18     
  Partials       21       21              
Impacted Files Coverage Δ
cmd/oras/internal/option/packer.go 81.25% <81.25%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit e9810a8 into oras-project:main Aug 15, 2022
TerryHowe pushed a commit to TerryHowe/oras that referenced this pull request Feb 2, 2023
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants