Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add new line to prettify manifest fetch result #499

Merged
merged 3 commits into from
Aug 16, 2022

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Aug 16, 2022

So linux prompt will not be shown right after the prettified result.

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2022

Codecov Report

Merging #499 (f375b07) into main (7c6fbdb) will increase coverage by 16.21%.
The diff coverage is 80.92%.

@@             Coverage Diff             @@
##             main     #499       +/-   ##
===========================================
+ Coverage   55.69%   71.90%   +16.21%     
===========================================
  Files           6        9        +3     
  Lines         237      388      +151     
===========================================
+ Hits          132      279      +147     
+ Misses         90       87        -3     
- Partials       15       22        +7     
Impacted Files Coverage Δ
internal/cache/target.go 72.46% <60.46%> (ø)
cmd/oras/internal/option/packer.go 81.25% <81.25%> (ø)
internal/cas/fetch.go 90.90% <90.90%> (ø)
cmd/oras/internal/option/platform.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit ee74ae2 into oras-project:main Aug 16, 2022
TerryHowe pushed a commit to TerryHowe/oras that referenced this pull request Feb 2, 2023
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants