Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add pre-defined annotation keys into option.Packer #502

Merged
merged 5 commits into from
Aug 18, 2022

Conversation

junczhu
Copy link
Contributor

@junczhu junczhu commented Aug 17, 2022

Defined pre-defined annotation keys in option.Packer, and replaced other const defined with the same value.

Updated annotation related example description.

Signed-off-by: Juncheng Zhu <junczhu@microsoft.com>
Signed-off-by: Juncheng Zhu <junczhu@microsoft.com>
@junczhu junczhu changed the title chore: add Pre-Defined Annotation Keys into option.packer refactor: add pre-defined annotation keys into option.Packer Aug 18, 2022
Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Juncheng Zhu <junczhu@microsoft.com>
Signed-off-by: Juncheng Zhu <junczhu@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2022

Codecov Report

Merging #502 (dc44e15) into main (15a9eb9) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #502   +/-   ##
=======================================
  Coverage   72.68%   72.68%           
=======================================
  Files           9        9           
  Lines         388      388           
=======================================
  Hits          282      282           
  Misses         85       85           
  Partials       21       21           
Impacted Files Coverage Δ
cmd/oras/internal/option/packer.go 81.25% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 3fc3415 into oras-project:main Aug 18, 2022
TerryHowe pushed a commit to TerryHowe/oras that referenced this pull request Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants