Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: rename the --manifest-config to --config #504

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

lizMSFT
Copy link
Contributor

@lizMSFT lizMSFT commented Aug 18, 2022

  • Rename current -c/--config option to --registry-config
  • Rename --manifest-config to --config

Resolves: #495
Signed-off-by: Zoey Li zoeyli@microsoft.com

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2022

Codecov Report

Merging #504 (50dc7a7) into main (4c786aa) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #504   +/-   ##
=======================================
  Coverage   71.90%   71.90%           
=======================================
  Files           9        9           
  Lines         388      388           
=======================================
  Hits          279      279           
  Misses         87       87           
  Partials       22       22           
Impacted Files Coverage Δ
cmd/oras/internal/option/remote.go 59.04% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Zoey Li <zoeyli@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit a4da0a3 into oras-project:main Aug 18, 2022
TerryHowe pushed a commit to TerryHowe/oras that referenced this pull request Feb 2, 2023
Signed-off-by: Zoey Li <zoeyli@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ORAS pull manifest config: rename the --manifest-config to --config
3 participants