Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add doc comments for the loop of successors #508

Merged
merged 2 commits into from
Aug 19, 2022
Merged

docs: add doc comments for the loop of successors #508

merged 2 commits into from
Aug 19, 2022

Conversation

wangxiaoxuan273
Copy link
Contributor

Note that there are comments in line 115-119.
This pr adds additional comments before and inside the loop of successors to describe what the loop does.

Part of issue #415

Signed-off-by: wangxiaoxuan273 wangxiaoxuan119@gmail.com

Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
cmd/oras/pull.go Outdated Show resolved Hide resolved
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #508 (6276a42) into main (a5aa136) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #508   +/-   ##
=======================================
  Coverage   72.68%   72.68%           
=======================================
  Files           9        9           
  Lines         388      388           
=======================================
  Hits          282      282           
  Misses         85       85           
  Partials       21       21           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit a6a360e into oras-project:main Aug 19, 2022
@wangxiaoxuan273 wangxiaoxuan273 deleted the docs-comment branch August 19, 2022 01:10
TerryHowe pushed a commit to TerryHowe/oras that referenced this pull request Feb 2, 2023
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants