feat: support specifying distribution spec in discover, cp and manifest push commands #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## main #757 +/- ##
==========================================
+ Coverage 63.68% 63.86% +0.17%
==========================================
Files 19 19
Lines 705 714 +9
==========================================
+ Hits 449 456 +7
Misses 225 225
- Partials 31 33 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
shizhMSFT
reviewed
Jan 20, 2023
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
shizhMSFT
reviewed
Jan 20, 2023
cmd/oras/internal/option/remote.go
Outdated
Comment on lines
67
to
69
| func generatePrefix(prefix, description string) (flagPrefix, notePrefix string) { | ||
| return prefix + "-", description + " " | ||
| } |
There was a problem hiding this comment.
Suggested change
| func generatePrefix(prefix, description string) (flagPrefix, notePrefix string) { | |
| return prefix + "-", description + " " | |
| } | |
| func applyPrefix(prefix, description string) (flagPrefix, notePrefix string) { | |
| if prefix == "" { | |
| return "", "" | |
| } | |
| return prefix + "-", description + " " | |
| } |
TerryHowe
pushed a commit
to TerryHowe/oras
that referenced
this pull request
Feb 2, 2023
…st push commands (oras-project#757) Resolves oras-project#756 Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #756
Signed-off-by: Billy Zha jinzha1@microsoft.com