Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support binary target in oras cp #843

Merged
merged 3 commits into from
Feb 28, 2023

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Feb 28, 2023

What this PR does / why we need it:
This PR fix a bug in oras cp: when copying with --resolve provided for destination target, the provided value will be silently ignored.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #842

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov-commenter
Copy link

Codecov Report

Merging #843 (6222ee9) into main (fc7a82b) will decrease coverage by 0.31%.
The diff coverage is 25.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #843      +/-   ##
==========================================
- Coverage   67.54%   67.23%   -0.31%     
==========================================
  Files          21       21              
  Lines         875      876       +1     
==========================================
- Hits          591      589       -2     
- Misses        239      242       +3     
  Partials       45       45              
Impacted Files Coverage Δ
cmd/oras/internal/option/target.go 19.56% <0.00%> (-0.66%) ⬇️
cmd/oras/internal/option/remote.go 70.53% <100.00%> (-0.29%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 12097db into oras-project:main Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resolve flag not working for destination target in oras cp
3 participants