Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve TODO in crate-exporter.py #702

Closed
pooja1pathak opened this issue Nov 15, 2022 · 2 comments
Closed

Resolve TODO in crate-exporter.py #702

pooja1pathak opened this issue Nov 15, 2022 · 2 comments

Comments

@pooja1pathak
Copy link
Collaborator

Resolve TODO at:

ngsi-timeseries-api/timescale-container/crate-exporter.py

Line 76 in af8877c

v = str(x) # TODO consider escaping?

@Ravisaketi Ravisaketi mentioned this issue Nov 21, 2022
Closed
12 tasks
@pooja1pathak
Copy link
Collaborator Author

@c0c0n3 I have gone through your comment on #704.
Can we go with the implementation as in

ngsi-timeseries-api/timescale-container/quantumleap-db-setup.py

Line 173 in 270a4e2

def to_string(x) -> str:
for escaping? Please let me know your opinion on this so I can raise a fresh PR.

@c0c0n3
Copy link
Member

c0c0n3 commented Jun 4, 2024

@pooja1pathak yes, good idea! I'd drop #704 and start from scratch w/ the approach you suggested.

@pooja1pathak pooja1pathak mentioned this issue Jun 5, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@c0c0n3 @pooja1pathak