more clarity for example test setup #15
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the changes I made are not obvious:
path.base
config variable ingetEnvironmentSetUp()
The way it was, the base path was
/path/to/project/workbench/myproject/mypackage/vendor/orchestra/testbench/src/fixture
which meant that in order for a package developer to set the path to their own migrations, the--path
setting for the migration had to be something like../../../../../tests/migrations
which I found non-obvious and a bit cumbersome.I think the
DatabaseFixtureTest
will still run successfully as-is, but I added some commented out sections that mirror what I'm doing in the test for the package I'm developing right now. I think others might find them useful as well. I'm relatively new to Laravel. Just started my first project about two weeks ago, so I'm still figuring out how the whole thing fits together.That's it. Hope this helps!