Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more clarity for example test setup #15

Merged
merged 1 commit into from
Oct 14, 2013
Merged

more clarity for example test setup #15

merged 1 commit into from
Oct 14, 2013

Conversation

morphatic
Copy link
Contributor

In case the changes I made are not obvious:

  • I reset the path.base config variable in getEnvironmentSetUp()

The way it was, the base path was /path/to/project/workbench/myproject/mypackage/vendor/orchestra/testbench/src/fixture which meant that in order for a package developer to set the path to their own migrations, the --path setting for the migration had to be something like ../../../../../tests/migrations which I found non-obvious and a bit cumbersome.

  • I added some commented out suggestions for potentially common testing scenarios

I think the DatabaseFixtureTest will still run successfully as-is, but I added some commented out sections that mirror what I'm doing in the test for the package I'm developing right now. I think others might find them useful as well. I'm relatively new to Laravel. Just started my first project about two weeks ago, so I'm still figuring out how the whole thing fits together.

That's it. Hope this helps!

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 1508e30 on morphatic:master into c3626b4 on orchestral:master.

@crynobone
Copy link
Member

You could use realpath(DIR) from inside your test directory to avoid
relative path.

On Monday, October 14, 2013, Coveralls wrote:

[image: Coverage Status] https://coveralls.io/builds/258760

Coverage remained the same when pulling *1508e301508e304713f20301be39f62aa250b16036dc6ddon morphatic:master


Reply to this email directly or view it on GitHubhttps://github.com//pull/15#issuecomment-26238164
.

Sent from Gmail Mobile

@crynobone crynobone merged commit 1508e30 into orchestral:master Oct 14, 2013
@crynobone
Copy link
Member

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants