Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

persist: false interferes with .addOption() #145

Closed
trullock opened this issue Jul 14, 2021 · 1 comment
Closed

persist: false interferes with .addOption() #145

trullock opened this issue Jul 14, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@trullock
Copy link

trullock commented Jul 14, 2021 •
edited
Loading

Repro: https://jsfiddle.net/o5pq9f1h/

click in the box, select aaa, remove aaa, refocus or type a, the aaa option is no longer there.

I wouldn't expect persist: false to make the options added via addOption() not persist....
@trullock trullock added the bug Something isn't working label Jul 14, 2021
oyejorge added a commit that referenced this issue Jul 15, 2021
@oyejorge
addOption() should not treat new options as user created by default #145
51a3826
@oyejorge
Copy link
Member

The fix for this needed a slight change to the API so I've put it in the 2.0 branch and I just pushed out Beta.1

@trullock trullock changed the title persist: true interferes with .addOption() persist: false interferes with .addOption() Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trullock @oyejorge