Skip to content
This repository has been archived by the owner on Apr 21, 2022. It is now read-only.

Only keep seconds on ISO8601 format #19

Merged
merged 1 commit into from
Apr 16, 2019

Conversation

shiveenp
Copy link
Contributor

Description

Fix for the issue where when no dtstart is specified, using todays utc date causes us to include millis/micros and nanos in output.

Changes

  • Explicitly specify second format

@ordermentum
Copy link

ordermentum bot commented Apr 16, 2019

Please make sure to add screenshots or gifs of the change to give a clear
picture of the change. If a design PR was made please make sure to link to it along with the
JIRA ticket. A Design PR will avoid unnecessary rework that might come up in a PR.

Good Pull Requests adhere to a single responsibility.

  • Break big changes into smaller Pull Requests
  • Big changes increase risk - smaller PRs are easier to review
  • Refactoring changes should be in seperate PRs to avoid noise
  • A story/ticket can have more than 1 PR

Some guidelines on giving and receiving feedback in Code Reviews

@shiveenp shiveenp merged commit 09111cc into master Apr 16, 2019
@shiveenp shiveenp deleted the feature/only-keep-seconds-on-iter-dates branch April 16, 2019 03:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant