This repository has been archived by the owner on Apr 21, 2022. It is now read-only.
Feature/parse rrule to json #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please make sure to add screenshots or gifs of the change to give a clear Good Pull Requests adhere to a single responsibility.
Some guidelines on giving and receiving feedback in Code Reviews |
| .expect("unsuccessful parse") // unwrap the parse result | ||
| .next().unwrap(); | ||
| .next() | ||
| .unwrap(); |
There was a problem hiding this comment.
.map_err is your friend with https://boats.gitlab.io/failure/ to handle parsing errors.
…multiple asignments
| rrule_string: "FREQ=DAILY", | ||
| expected_flat_json: r#"{"frequency":"DAILY"}"#, | ||
| }, | ||
| RRuleTestCase { |
There was a problem hiding this comment.
you could write this as a macro. but that is for another day... 💃
There was a problem hiding this comment.
thanks! will try to incorporate in the next PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable parsing of RRule to Json