Skip to content
This repository has been archived by the owner on Apr 21, 2022. It is now read-only.

Feature/handle yearly rrule #4

Merged
merged 15 commits into from
Mar 18, 2019
Merged

Feature/handle yearly rrule #4

merged 15 commits into from
Mar 18, 2019

Conversation

shiveenp
Copy link
Contributor

Description

Adds support for yearly rule with an implementation that matches lunartick

@ordermentum
Copy link

ordermentum bot commented Mar 18, 2019

Please make sure to add screenshots or gifs of the change to give a clear
picture of the change. If a design PR was made please make sure to link to it along with the
JIRA ticket. A Design PR will avoid unnecessary rework that might come up in a PR.

Good Pull Requests adhere to a single responsibility.

  • Break big changes into smaller Pull Requests
  • Big changes increase risk - smaller PRs are easier to review
  • Refactoring changes should be in seperate PRs to avoid noise
  • A story/ticket can have more than 1 PR

Some guidelines on giving and receiving feedback in Code Reviews

@shiveenp shiveenp requested a review from bassjacob March 18, 2019 01:33
@shiveenp shiveenp merged commit 3da612b into master Mar 18, 2019
@shiveenp shiveenp deleted the feature/handle-yearly-rrule branch March 18, 2019 05:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant