Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add python media type #2538

Merged
merged 7 commits into from
Oct 26, 2023
Merged

add python media type #2538

merged 7 commits into from
Oct 26, 2023

Conversation

elocremarc
Copy link
Contributor

Add file type python closes #1481

@elocremarc
Copy link
Contributor Author

elocremarc commented Oct 16, 2023 •
edited
Loading

@raphjaph I was realizing after I submitted this that the mime-type returned for the highlight code JS is gonna be text/x-python This won't be recognized as a type for highlight Js. Do you think it would be worth making a more generic highlight JS template with auto highlight to support adding executable code like rust or say typescript? We have the optimized one already where we specify the languge for code types that are used in inscriptions. However any other code that is just reference code using ord as a CDN we would fallback to auto highlight these ones won't be rendered nearly as often.

Another option is we could just regex if the mimetype contains python then set it to the correct name to pass in as language variable.

@elocremarc elocremarc mentioned this pull request Oct 16, 2023
Closed
@elocremarc
Copy link
Contributor Author

@raphjaph got highlight working with latest commit.
image

@casey casey added the stream label Oct 25, 2023
casey
casey reviewed Oct 26, 2023
View reviewed changes
static/preview-code.js Outdated

const inscription = document.documentElement.dataset.inscription;
const response = await fetch(`/content/${inscription}`);
const contentType = response.headers.get("content-type");
const language = contentType.split("/")[1];
let language = contentType.split("/")[1];
if (language.includes("python")) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (language.includes("python")) {
if (language === "x-python") {

casey
casey approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG

@casey casey enabled auto-merge (squash) October 26, 2023 00:43
@casey casey merged commit 231bdda into ordinals:master Oct 26, 2023
6 checks passed
@elocremarc elocremarc mentioned this pull request Oct 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casey casey casey approved these changes

Assignees
No one assigned
Labels
stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add python content type
3 participants
@elocremarc @casey @raphjaph