Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add attoseconds accessor #3

Merged

Conversation

hassila
Copy link
Contributor

@hassila hassila commented Nov 28, 2022

Description

Add attoseconds accessor for instant, rename seconds accessor

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Minimal checklist:

  • [x ] I have performed a self-review of my own code
  • I have added DocC code-level documentation for any public interfaces exported by the package
  • I have added unit and/or integration tests that prove my fix is effective or that my feature works

@shortcut-integration
Copy link

@mr-swifter
Copy link

Will you add init from seconds and attoseconds in the same PR? or?

@github-actions
Copy link

github-actions bot commented Nov 28, 2022

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #3 (f885861) into main (26f1193) will decrease coverage by 2.28%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
- Coverage   36.76%   34.48%   -2.28%     
==========================================
  Files           3        3              
  Lines         136      145       +9     
==========================================
  Hits           50       50              
- Misses         86       95       +9     
Impacted Files Coverage Δ
Sources/DateTime/InternalUTCClock.swift 43.21% <0.00%> (-5.40%) ⬇️
Impacted Files Coverage Δ
Sources/DateTime/InternalUTCClock.swift 43.21% <0.00%> (-5.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26f1193...f885861. Read the comment docs.

@hassila
Copy link
Contributor Author

hassila commented Nov 28, 2022

Will you add init from seconds and attoseconds in the same PR? or?

f885861

@hassila hassila merged commit ccdb50c into main Nov 28, 2022
@hassila hassila deleted the feature/sc-858/kill-timestamp-from-datamodel-use-utc-clock branch November 28, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants