Skip to content

Create Exercises_5.cpp #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2017
Merged

Conversation

jsxyhelu
Copy link
Contributor

@jsxyhelu jsxyhelu commented Jun 8, 2017

Create Exercises of chapter 5

Create Exercises of chapter 5
@jsxyhelu
Copy link
Contributor Author

jsxyhelu commented Jun 8, 2017

wait for permit.

@garybradski garybradski self-assigned this Jun 9, 2017
Copy link
Collaborator

@garybradski garybradski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is generally good. I prefer a little "void help(char** argv) function that tells what each function does when it runs. See, for example: example_15-01.cpp.

@garybradski
Copy link
Collaborator

See my comment, I prefer a "help function" as in example_15-01.cpp https://github.com/oreillymedia/Learning-OpenCV-3_examples/blob/master/example_15-01.cpp but this is acceptable now. Thanks!

@garybradski garybradski merged commit 69bb1cb into oreillymedia:master Jun 9, 2017
@jsxyhelu
Copy link
Contributor Author

Great. I'll keep improving。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants