Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locale list #11

Closed
Louvas opened this issue Apr 28, 2020 · 2 comments
Closed

locale list #11

Louvas opened this issue Apr 28, 2020 · 2 comments

Comments

@Louvas
Copy link

Louvas commented Apr 28, 2020

Hello @ORelio ,

As also related in issues #6 and #7, changing the locale to get more images was too much trouble since there are so many to choose from. I decide to test and try an extensive list of locales and see what works with Spotlight. I've added each of them as an extra command line inside the .bat file so every time it finishes to execute with one locale it goes to the next one and so on. Usually with the first pass it downloads +600 different images using the 318 different locales.

I've attached the list of locales I've being using (most likely all that Spotlight supports - give or take). Hopefully this information will help to implement them within the code as default, making it possible to download as much images as possible without the hassle to edit the batch file to add hundreds of extra command lines.

Thank you!

locales.txt

@ORelio
Copy link
Owner

ORelio commented Apr 29, 2020

Congrats for identifying the list of valid locales supported by the Spotlight API 👍

I'll try to add something like --all-locales to collect images in all languages. The only issue I see with this approach would be metadata harvesting with --metadata that would collect image descriptions in random languages, that would be not very useful. Maybe Spotlight Downloader should display a warning if using --all-locales in combination with --metadata 🤔

ORelio added a commit that referenced this issue May 1, 2020
At the expense of not having metadata, try downloading images
for all known spotlight locales sequentially with --all-locales
@ORelio
Copy link
Owner

ORelio commented May 1, 2020

This is now implemented as per release v1.4.3. Thanks 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants