Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve WannaHelpController #82

Closed
orendon opened this issue Dec 14, 2012 · 3 comments
Closed

Improve WannaHelpController #82

orendon opened this issue Dec 14, 2012 · 3 comments
Labels
refactoring

Comments

@orendon
Copy link
Owner

orendon commented Dec 14, 2012

Improve WannaHelpController to reduce method complexity, also tests are welcome https://codeclimate.com/github/orendon/contrib-hub/WannahelpController
@jlstr
Copy link
Contributor

jlstr commented Dec 15, 2012

This looks like quite a challenge. Perhaps, what could help would be to create a Search model and move parameterization of queries into methods? Anyways, that's like my first thought.

@barisbalic barisbalic mentioned this issue Dec 16, 2012
Merged
orendon pushed a commit that referenced this issue Dec 20, 2012
Refactored the search filter as suggested in issue #82 to reduce meth…
257ece5 
…od complexity.
@jasnow
Copy link
Contributor

jasnow commented Mar 10, 2013

This issue might be ready to be closed if Pull Request #92 solved it.

@orendon
Copy link
Owner Author

orendon commented Dec 4, 2013

You're right @jasnow it was fixed by #92

@orendon orendon closed this as completed Dec 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jasnow @jlstr @orendon