Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile #319

Merged
merged 1 commit into from
Jul 8, 2023
Merged

Update Dockerfile #319

merged 1 commit into from
Jul 8, 2023

Conversation

ymosy
Copy link
Contributor

@ymosy ymosy commented Jul 1, 2023

Hi. I noticed that #303 is open and decided to help with a quick Dockerfile update.

Build:

docker build -t gping .

Run:

docker run -it --rm gping google.com

Hope this helps!

Full changelog is below:

  • Switch to Debian 12 "bookworm"
  • Adjust cargo install command
  • Switch to iputils-ping as required by gping
  • Format Dockerfile

* Switch to Debian 12 "bookworm"
* Adjust cargo install command
* Switch to iputils-ping as required by gping
* Format Dockerfile
@orf
Copy link
Owner

orf commented Jul 1, 2023

Thank you! This looks good, I’ll push some CI changes to also publish this image to the GitHub package registry.

I will keep this PR open to remind me to do this, unless you also fancy adding a GitHub actions step to do this.

@ymosy
Copy link
Contributor Author

ymosy commented Jul 1, 2023

Glad to help! Sorry, but I'm not too familiar with multiplatform Rust builds so I guess I'd rather leave that part to someone more experienced.

@orf orf merged commit 97596d8 into orf:master Jul 8, 2023
@orf
Copy link
Owner

orf commented Jul 8, 2023

It's now automatically publishing: https://github.com/orf/gping/pkgs/container/gping

You should be able to use docker pull ghcr.io/orf/gping:master. The next time I do a release it should be tagged correctly.

Thanks for the contribution!

@ymosy ymosy deleted the patch-1 branch July 22, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants