Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite handler #211

Merged
merged 4 commits into from
Jul 8, 2021
Merged

Rewrite handler #211

merged 4 commits into from
Jul 8, 2021

Conversation

AnneThKu
Copy link
Contributor

Adding rewrite handler to the Webserver to allow to rewrite and redirect URLs before they reach the contexts.
Changes done:

  • Added a new API addRule, to add rewrite/redirect rules to the RewriteHandler.
  • Setting the RewriteHandler to the GzipHandler.

@notthetup
Copy link
Collaborator

notthetup commented Jun 30, 2021 •
edited
Loading

I don't think PR is ready for review yet. We should wait for #212 to get merged first and then rebase this. Maybe we can mark it as Draft?

@notthetup notthetup marked this pull request as draft June 30, 2021 02:57
@AnneThKu AnneThKu requested a review from mchitre July 5, 2021 10:18
@AnneThKu AnneThKu marked this pull request as ready for review July 5, 2021 10:19
@AnneThKu AnneThKu requested a review from notthetup July 7, 2021 06:13
@AnneThKu AnneThKu merged commit 372dd8e into org-arl:dev Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notthetup notthetup notthetup approved these changes

@mchitre mchitre mchitre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AnneThKu @notthetup @mchitre