Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table of contents #76

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Table of contents #76

merged 2 commits into from
Sep 9, 2024

Conversation

jjophi
Copy link
Collaborator

@jjophi jjophi commented Aug 5, 2024

Added a view for listing links to all blogs. This view is available in home page and individual blog pages. Please see the screens:

Screenshot 2024-08-05 at 8 23 19 PM Screenshot 2024-08-05 at 8 23 30 PM

@manuignatius
Copy link
Collaborator

For @mchitre @notthetup 's context, I had requested this feature here: #70

@manuignatius manuignatius changed the title Blog list table of content Table of contents Aug 5, 2024
Copy link
Member

@mchitre mchitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really in a position to technically review. @manuignatius and @notthetup's reviews should be sufficient.

@manuignatius
Copy link
Collaborator

Not really in a position to technically review. @manuignatius and @notthetup's reviews should be sufficient.

Mostly for the overall OK that I requested your review :)

@notthetup
Copy link
Collaborator

What's the mechanism for opening this list?

@jjophi
Copy link
Collaborator Author

jjophi commented Aug 8, 2024

What's the mechanism for opening this list?

You can click on the Table of contents button:

image

@notthetup
Copy link
Collaborator

The placement of that button doesn't go with the rest of the design no?

Does it make sense to just have a separate "page" called /all which we can then link from the top menubar instead of doing this overlay?

@manuignatius
Copy link
Collaborator

Decided to go with @notthetup 's suggestion during today's (8 August 2024) meeting.

@jjophi
Copy link
Collaborator Author

jjophi commented Aug 8, 2024

Updated the blog listing UI as discussed today (8 August 2024). Main changes are:

  • 'Blog List' link added along with the main links
  • separate page for blog listing (removed overlay)

Please see the UI:

image

@manuignatius
Copy link
Collaborator

@notthetup for your review and approval

_includes/blog_list.html Outdated Show resolved Hide resolved
@manuignatius manuignatius merged commit 3136279 into master Sep 9, 2024
@manuignatius manuignatius deleted the blog-listing branch September 9, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants