Provide a way to merge and "follow up" on a PR review #132807
Replies: 1 comment
-
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
Beta Was this translation helpful? Give feedback.
-
Select Topic Area
Product Feedback
Body
Apologies if this has already been discussed! I couldn't find anything about it via search.
I work on a project that makes use of a "pull request flow" for merging changes: every issue gets a feature branch (or potentially many) and we require at least one review before merging to the main branch. Quite often, I'll find I'm reviewing something that would be good to tweak, but that I don't want to block from merging (it'd be good to do some small renames or make some minor modifications to test for example).
In this case, a nice approach is to comment on the things I'd like changed as part of the review, submit the review as "Approved" and then create an issue linking to the review (or comments individually) as a follow-up. I know that this of course requires trust that the issue actually gets done (and ideally quickly after), but that's a team/project management problem rather a tools one as far as I'm concerned. The goal here is just to be able to merge things that make forward progress, but still make it easy to track improvements you want to make. This is all doable currently, but pretty clunky.
My ideal would be that Github provides a new review status that allows merging (I'd imagine it'd be configurable at a repo level) and automatically creates an issue linking to the individual review comments with some nice UI in both the issue and the PR itself for displaying that these are linked (and making it easy to follow up on the comments).
Failing that, I'm guessing this is possible with a clever Github Action. If I give that a go and end up somewhere nice I'll share that here.
Beta Was this translation helpful? Give feedback.
All reactions