Unable to remove reviewers occasionally #69208
Replies: 4 comments
-
I've had this same issue on a PR that was closed two years ago. It's been stuck on my review-requested:@me list for years, it would be nice to get rid of it. |
Beta Was this translation helpful? Give feedback.
-
This continues to be annoying for me too. How can we get this raised in priority to see some action? |
Beta Was this translation helpful? Give feedback.
-
For me this is not occasionally, it is every time I am initially creating a PR. |
Beta Was this translation helpful? Give feedback.
-
+1 I'm starting to see this from time to time. Really frustrating as reviews just start piling up :( |
Beta Was this translation helpful? Give feedback.
-
Select Topic Area
Bug
Body
Hi team,
Regularly on GitHub we are seeing issues where a pending reviewer cannot be removed from a pull request (note: we do not use codeowners). When the UI combobox for reviewers opens, we can uncheck the reviewer, but upon closing the panel, the reviewer is not removed. This can be tried repeatedly but never ends up working.
Reproduction Steps
Here is an example where alxhub@ cannot be removed: angular/angular#51807
Unclear how it can be reproduced. It happens randomly. I suspect somehow the internal state is messed up when a PR is created, reviewers are requested by a bot (and then sometimes removed by the user via UI again where the bot re-adds reviewers instantly).
Here is a video:
Screen.Recording.2023-08-24.at.16.04.21.1.mov
The devtools show an error when the reviewers are removed and the panel closes. Somehow a 404 is returned.
Trying to remove the reviewer via REST API does not work either.
Fault Type
Permanent - Occurring repeatably
Blocking?
Yes, with strict reviewer policies, this can block merging PRs
Beta Was this translation helpful? Give feedback.
All reactions