How to determine a Pull request has been merged ?

[nhuray]

Hi community,

I have a stupid question: How to determine a Pull request has been merged ?

My assumption would be to create a rule like that:

    # Rule to determine if the pull request has been merged
    - name: is-merged
      spec: '$state() == "closed" && $head() == $head("main")'

But is it the right approach ?

Thanks

[ferreiratiago]

Hi @nhuray

Thanks for the question. Your solution is a good start, but it doesn't address all the possible cases. We might need to come up with a more robust solution.

As it is right now, the rule will only work for the pull requests to main and give a positive result if a pull request is closed without being merged.

We're currently working on a solution to this problem. We are building a new built-in isMerged. You can expect it to be released in the next version of Reviewpad (planned for this Thursday).

Please keep an eye on this thread. I'll update it once the new builtin is released 🙂

[ferreiratiago]

Hi @nhuray

Today we have released a new version of Reviewpad - Reviewpad v3.17.0 - that includes the new built-in isMerged.

Please give it a try and let us know what you think 🙏