-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(args): allow -o and -p together if they point to different files #653
Conversation
Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️ |
setting prepend and output together will ignore the prepend flag Signed-off-by: Anton Engelhardt <antoncengelhardt@icloud.com>
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #653 +/- ##
==========================================
- Coverage 41.90% 41.65% -0.24%
==========================================
Files 15 15
Lines 1079 1083 +4
==========================================
- Hits 452 451 -1
- Misses 627 632 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
… arg Signed-off-by: Anton Engelhardt <antoncengelhardt@icloud.com>
@orhun i ticked that this is a breaking change. Not sure though. WDYT? |
Ah, I found an issue: #120 It turns out someone actually requested this feature in the past, so I'm a bit unsure about merging this :/ I think we can bring back the note in the |
Yeah, I get your point. In my opinion, output and prepend should work together, but only if the file paths are not equal. If the file paths are the same, it does not make sense to use both flags and an error should be shown. Do you agree? |
Actually yes, that sounds more reasonable! |
Any idea for the error message? |
Something along the lines of "Output files cannot be the same" maybe |
Signed-off-by: Anton Engelhardt <antoncengelhardt@icloud.com>
Awesome, thanks! |
Congrats on merging your first pull request! ⛰️ |
setting prepend and output together will ignore the prepend flag
Description
Motivation and Context
orhun/git-cliff-action#21 (comment)
How Has This Been Tested?
I build it locally and tested it with one of my rust projects
Screenshots / Logs (if applicable)
Types of Changes
not sure
Checklist: