Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(example): allow using github template without github variables #672

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

R11baka
Copy link
Contributor

@R11baka R11baka commented Jun 3, 2024

Description

Fixed default template related in bug #659

Motivation and Context

How Has This Been Tested?

Screenshots / Logs (if applicable)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
    How to check ? run in shell
    cargo run --no-default-features -- -c examples/github.toml

@R11baka R11baka requested a review from orhun as a code owner June 3, 2024 07:14
Copy link

welcome bot commented Jun 3, 2024

Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.97%. Comparing base (2c2a300) to head (bbace25).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
+ Coverage   36.89%   36.97%   +0.08%     
==========================================
  Files          18       18              
  Lines        1350     1350              
==========================================
+ Hits          498      499       +1     
+ Misses        852      851       -1     
Flag Coverage Δ
unit-tests 36.97% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orhun
Copy link
Owner

orhun commented Jun 3, 2024

I will accept this as a short term solution, but it does not really fix the actual underlying issue.

/// Contributors.
#[cfg(feature = "github")]
pub github: RemoteReleaseMetadata,
/// Contributors.
#[cfg(feature = "gitlab")]
pub gitlab: RemoteReleaseMetadata,
/// Contributors.
#[cfg(feature = "bitbucket")]
pub bitbucket: RemoteReleaseMetadata,

We should instead have these structs available at all times (even though the feature isn't enabled) so that they are usable in the template although they are empty.

@orhun orhun changed the title fix(659) fix default template chore(example): allow using github template without github variables Jun 3, 2024
@orhun orhun merged commit 6a9feba into orhun:main Jun 3, 2024
43 of 44 checks passed
Copy link

welcome bot commented Jun 3, 2024

Congrats on merging your first pull request! ⛰️

@R11baka
Copy link
Contributor Author

R11baka commented Jun 3, 2024

@orhun thanks for advice. Will try to implement your solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants