Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template): include for-loop arguments in template variables #812

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

orhun
Copy link
Owner

@orhun orhun commented Aug 23, 2024

Description

Tobias Bieniek on Mastodon reported that even when he used the GitHub-related template variables in this comment, git-cliff wasn't querying GitHub.

The problem turned out to be in the AST parsing. It was simply not taking for-loop arguments into account.

Motivation and Context

Fixes the issue that mentioned above.

How Has This Been Tested?

Locally.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.75%. Comparing base (3b6156d) to head (2241703).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #812      +/-   ##
==========================================
+ Coverage   39.50%   39.75%   +0.25%     
==========================================
  Files          20       20              
  Lines        1633     1638       +5     
==========================================
+ Hits          645      651       +6     
+ Misses        988      987       -1     
Flag Coverage Δ
unit-tests 39.75% <100.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orhun orhun merged commit 9a6430b into main Aug 23, 2024
60 checks passed
@orhun orhun deleted the fix/include_for_loop_args_in_variables branch August 23, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants