Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let Control+W pass through #6

Closed
mawww opened this issue Oct 14, 2019 · 4 comments
Closed

Let Control+W pass through #6

mawww opened this issue Oct 14, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@mawww
Copy link

mawww commented Oct 14, 2019

Hello,

Currently k3rmit interprets Control+W as a tab closing command. This is a pretty common readline binding (that deletes the word before the cursor), so I would suggest to switch that to something else.

In general, I think it would be good to avoid binding anything to Control+Letter as those are frequently used by terminal applications.

@orhun orhun added the bug Something isn't working label Oct 14, 2019
@orhun
Copy link
Owner

orhun commented Oct 14, 2019

Hey,
Thanks for reporting this issue. I'll fix this when I got time to work on k3rmit. Do you have any suggestions for these key bindings other than Ctrl + key ?

@mawww
Copy link
Author

mawww commented Oct 14, 2019

Hello,

I dont rely on tabs at all, so I do not care that much where the binding ends up, but I'd suggest at least to move it to Control+Mod1+W as there is already other commands using those modifiers and it is less likely to conflict with terminal applications.

@orhun
Copy link
Owner

orhun commented Oct 15, 2019

I've changed the Ctrl + key bindings to Ctrl + action_key + key with 05744c0
Can you build from source and test if it works for your configuration?

@mawww
Copy link
Author

mawww commented Oct 17, 2019

Seems to work fine, thanks !

@mawww mawww closed this as completed Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants