Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query parameters serialized/deserialized twice in remote protocol. #2301

Closed
4 tasks done
enisher opened this issue Apr 30, 2014 · 4 comments
Closed
4 tasks done

Query parameters serialized/deserialized twice in remote protocol. #2301

enisher opened this issue Apr 30, 2014 · 4 comments
Assignees
Milestone

Comments

@enisher
Copy link
Contributor

enisher commented Apr 30, 2014

com.orientechnologies.orient.core.command.OCommandRequestTextAbstract#fromStream(com.orientechnologies.orient.core.serialization.OMemoryStream)

We serialize/deserialize the parameters twice. I suppose we do that by mistake. It looks really strange for the protocol users.

We serialize keys put them in document and then serialize document.

  • remove redundant serialization in client
  • remove redundant deserialization in server
  • update protocol version
  • log changes to the documentation
@enisher enisher added this to the 1.7 milestone Apr 30, 2014
@enisher enisher self-assigned this Apr 30, 2014
@phpnode
Copy link
Contributor

phpnode commented Apr 30, 2014

@enisher not only this, from the client's point of view we must guess whether a certain value should be twice encoded, if we blindly encode everything twice, orient gives us an error.

@enisher enisher removed their assignment May 16, 2014
@lvca lvca assigned lvca and enisher and unassigned lvca May 22, 2014
@lvca lvca modified the milestones: 1.7.1, 1.7 May 26, 2014
@lvca lvca modified the milestones: 1.7.2, 1.7.1, 1.7.3 Jun 4, 2014
@andrii0lomakin andrii0lomakin modified the milestones: 1.7.4, 1.7.3 Jun 12, 2014
@enisher enisher assigned andrii0lomakin and unassigned enisher Jun 12, 2014
@andrii0lomakin
Copy link
Member

@phpnode we can do this by looking at server and client protocol versions. so backward compatibility will be supported.

@phpnode
Copy link
Contributor

phpnode commented Jun 13, 2014

👍

@lvca lvca assigned tglman and unassigned andrii0lomakin Jun 15, 2014
@lvca
Copy link
Member

lvca commented Jun 15, 2014

I've assigned this to @tglman that is working on the binary protocol serialization.

@lvca lvca modified the milestones: 1.7.5, 1.7.4 Jun 23, 2014
@lvca lvca modified the milestones: 1.7.6, 1.7.5, 1.7.7 Jul 10, 2014
@lvca lvca removed the 1 - Next label Aug 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants