-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis & WordPress coding standards #15
Comments
I just don't like the wp coding standard about using underscores for naming functions and stuff. I prefer camelcase. But i think we should follow the codex right? And besides, you are the girl in charge here :) |
I get that. In a similar vain, I'm not a fan of yoda conditions. So what about using WPCS, but excluding the function naming rules ?
LOL, and there was me thinking it was your repo ;-) |
LOL
Don't like yoda conditions too. And to put curly braces on different lines neither.
Cool is it possible to do that? I prefer. I'm realizing i can learn with you and I feel so happy you thought this project is worth spending time. I have to admit I was thinking about putting it aside. So yes it's your repository too :) |
Yup, no problem, I'll just need to figure out which rules to exclude. I'll get this sorted once the three PRs I opened earlier are merged to avoid everything conflicting with different spacing and such.
Thank you 😊 That's very kind. |
PR #16 addresses this and selectively excludes a few rules. Have a look through if there are other rules you'd want to exclude as well or if you're ok with what I've done now. |
Would you be open to me adding a travis file which will run a PHP lint and do a code style check against the WP Coding standards sniffs ?
This would include some minor changes to make the current code comply with the coding standards.
The text was updated successfully, but these errors were encountered: