Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis & WordPress coding standards #15

Closed
jrfnl opened this issue Mar 16, 2016 · 5 comments
Closed

Travis & WordPress coding standards #15

jrfnl opened this issue Mar 16, 2016 · 5 comments

Comments

@jrfnl
Copy link
Collaborator

jrfnl commented Mar 16, 2016

Would you be open to me adding a travis file which will run a PHP lint and do a code style check against the WP Coding standards sniffs ?
This would include some minor changes to make the current code comply with the coding standards.

@pablo-sg-pacheco
Copy link
Member

I just don't like the wp coding standard about using underscores for naming functions and stuff. I prefer camelcase. But i think we should follow the codex right?

And besides, you are the girl in charge here :)
So yes, no problem.

@jrfnl
Copy link
Collaborator Author

jrfnl commented Mar 16, 2016

I just don't like the wp coding standard about using underscores for naming functions and stuff. I prefer camelcase.

I get that. In a similar vain, I'm not a fan of yoda conditions.
I know people can feel quite strong about their preferred coding standards, which is why I asked the question ;-)

So what about using WPCS, but excluding the function naming rules ?

And besides, you are the girl in charge here :)

LOL, and there was me thinking it was your repo ;-)

@pablo-sg-pacheco
Copy link
Member

LOL

I get that. In a similar vain, I'm not a fan of yoda conditions.

Don't like yoda conditions too. And to put curly braces on different lines neither.

So what about using WPCS, but excluding the function naming rules ?

Cool is it possible to do that? I prefer.

I'm realizing i can learn with you and I feel so happy you thought this project is worth spending time. I have to admit I was thinking about putting it aside. So yes it's your repository too :)

@jrfnl
Copy link
Collaborator Author

jrfnl commented Mar 16, 2016

Cool is it possible to do that? I prefer.

Yup, no problem, I'll just need to figure out which rules to exclude. I'll get this sorted once the three PRs I opened earlier are merged to avoid everything conflicting with different spacing and such.

I'm realizing i can learn with you and I feel so happy you thought this project is worth spending time. I have to admit I was thinking about putting it aside. So yes it's your repository too :)

Thank you 😊 That's very kind.
I generally will always try to give back to projects I use, so you're very welcome.

@jrfnl
Copy link
Collaborator Author

jrfnl commented May 3, 2016

PR #16 addresses this and selectively excludes a few rules. Have a look through if there are other rules you'd want to exclude as well or if you're ok with what I've done now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants